-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support devDependencies on package.json parser #174
feat: support devDependencies on package.json parser #174
Conversation
Hi @arthurdenner! Thank you for your PR. Since we don't often receive product functionality contributions we need to run it by team and I'll get back to you right afterwards. The code looks good so far ✔️ Apologise for the delay. |
@arthurdenner Apologise for taking it too long. We iterated with the team on how should we approach feature contributions. For instance, given we have other IDE plugins, we're trying to ensure we're consistent with our product functionality across all of them. That means if feature lands in VS Code extension, it should be also added to IntelliJ plugin, Visual Studio extension, etc. All in all we're ready to accept your PR, please resolve the conflicts and let me know. Thank you! |
3be3834
to
97a9dc5
Compare
@michelkaporin, I've updated the PR after solving the conflicts. |
97a9dc5
to
ad0d2e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you for your contribution 👏
Update: Just realised your commits should be signed before we merge in, please sign them 🙏
ad0d2e9
to
6c56b92
Compare
@michelkaporin, done! Apologies for the delay. |
Fixes #173.
Screenshot
As
--dev
is the trigger for scanningdevDependencies
, I've approached the issue like this:--dev
string inside the parameters (if provided)devDependencies
in the package.jsondevDependencies
as thedependencies
Let me know if you have suggestions for changes or if I have approached the issue incorrectly.