fix: token error #216
Merged
fix: token error #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attriaayush
force-pushed
the
fix/token-error
branch
from
b946d16 to
baa23a4
Compare
bastiandoetsch
approved these changes
Apr 28, 2022
| @@ -46,6 +46,9 @@ jobs: | |||
| environment: Stable | |||
| name: Release | |||
| steps: | |||
| - name: Fetch sources | |||
| uses: actions/checkout@v2 | |||
|
|
|||
| - name: Setup VSCE | |||
| run: sudo npm install -g vsce@latest | |||
|
|
|||
There was a problem hiding this comment.
npm install is missing here
|
@attriaayush changelog entry is missing as well as bumping up package.json version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TIL: Thenable errors are not caught within a try/catch block so need to create a new promise out of Thenables to correctly handle with the errors.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!