Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporarily prevent rejecting Code API requests if CA check not passing #67

Closed
wants to merge 1 commit into from

Conversation

michelkaporin
Copy link
Contributor

@michelkaporin michelkaporin commented Oct 1, 2021

Snyk VS Code extension is not working at the moment due to electron/electron#31212 and microsoft/vscode#134244.

Temporarily fix our extension by preventing rejecting Code API requests if CA check not passing.

Update: we decided not to proceed with this temporarily fix to ensure our customers stay fully secure. We will investigate better options that do not trade off security.

@michelkaporin michelkaporin requested a review from a team October 1, 2021 10:43
@pkey pkey self-requested a review October 1, 2021 11:03
Copy link

@pkey pkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folks, I don't think this is a great idea. Let's discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants