-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make basename optional #280
Comments
Can you give me a real world example of where/how this would change the d-s-f output? |
Any diff where the file is in a subdirectory. |
Ahhh I see... Honestly I don't know why we did it this way at all. It probably should just be the full path in the hunk line. Should we make this the default? Or make it an optional setting? |
I vote for making it the default. |
For what it's worth, I think my vote is making it default as well. |
yeah seems good. let's do the full path. |
Ok this should be fixed in 49969f0. If there is anything else on this let me know and I'll reopen. |
I prefer not having
basename
called inside the hunk - since this is where the line number is appended, and therefore is good for copy'n'pasting into your editor.Currently there is
foo:42
, but the original would bebar/foo:42
.Related discussion: #100 (comment)
The text was updated successfully, but these errors were encountered: