Make basename optional

[blueyed]

I prefer not having basename called inside the hunk - since this is where the line number is appended, and therefore is good for copy'n'pasting into your editor.

Currently there is foo:42, but the original would be bar/foo:42.

diff --git i/diff-so-fancy w/diff-so-fancy
index bece8e0..cd1397a 100755
--- i/diff-so-fancy
+++ w/diff-so-fancy
@@ -241,7 +241,7 @@ sub do_dsf_stuff {
                        }
 
                        my ($orig_offset, $orig_count, $new_offset, $new_count) = parse_hunk_
-                       $last_file_seen = basename($last_file_seen);
+                       # $last_file_seen = basename($last_file_seen);
 
                        # Figure out the start line
                        my $start_line = start_line_calc($new_offset,$new_count);

Related discussion: #100 (comment)

[scottchiefbaker]

Can you give me a real world example of where/how this would change the d-s-f output?

[blueyed]

Any diff where the file is in a subdirectory.

[scottchiefbaker]

Ahhh I see... Honestly I don't know why we did it this way at all. It probably should just be the full path in the hunk line.

Should we make this the default? Or make it an optional setting?

[blueyed]

I vote for making it the default.
/cc @paulirish

[scottchiefbaker]

For what it's worth, I think my vote is making it default as well.

[paulirish]

yeah seems good. let's do the full path.

[scottchiefbaker]

Ok this should be fixed in 49969f0. If there is anything else on this let me know and I'll reopen.