Try and be smart about what line the diff starts on #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1: @@ -1,4 +1,4 @@ 2: @@ -1,5 +1,5 @@ 3: @@ -1,6 +1,6 @@ 4: @@ -1,7 +1,7 @@ 5: @@ -2,6 +2,7 @@ 6: @@ -3,7 +3,7 @@ Starting from the end (last line (10), second to last line (9))... -1: @@ -7,4 +7,4 @@ -2: @@ -6,5 +6,5 @@ -3: @@ -5,6 +5,6 @@ -4: @@ -4,7 +4,7 @@
|
ah interesting that none of our tests hit this. @stevemao when you get a second, maybe you could toss one in, so we keep things consistent? |
paulirish
added a commit
that referenced
this pull request
Mar 17, 2016
Try and be smart about what line the diff starts on
stevemao
added a commit
that referenced
this pull request
Mar 21, 2016
When diff starts in the first three lines Closes #120
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been testing this for a couple of days now and I'm pretty confident it's accurate. This should fix #120.