Add pro-tip about hg diff #379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When line numbers are shown in less, the horizontal ruler would wrap around if line wrapping is turned on, there're 2 options: 1. turn off line wrapping in less, using `-S` 2. decrease horizontal_rule width, e.g.: `$width -= 8`, to accommodate line numbers up to 4 digits. I added `-S`, but It should be fine to use either here.
avoid line wrapping in less
We end up getting a lot of bug reports due to broken tput installations. This will wrapper tput and keep errors to a minimum
|
This looks good to me. Pull Requests should target the next branch. Update this to target |
|
I forgot a variable in the command. It should terminate with It should be: I'm surprised to see that this PR has some additional commits merged into it. Should I update my branch and apply it to the PR, or should I create new PR with the fix? |
|
You must have done a Once the PR is clean I'll merge it. |
We end up getting a lot of bug reports due to broken tput installations. This will wrapper tput and keep errors to a minimum
When line numbers are shown in less, the horizontal ruler would wrap around if line wrapping is turned on, there're 2 options: 1. turn off line wrapping in less, using `-S` 2. decrease horizontal_rule width, e.g.: `$width -= 8`, to accommodate line numbers up to 4 digits. I added `-S`, but It should be fine to use either here.
We end up getting a lot of bug reports due to broken tput installations. This will wrapper tput and keep errors to a minimum
When line numbers are shown in less, the horizontal ruler would wrap around if line wrapping is turned on, there're 2 options: 1. turn off line wrapping in less, using `-S` 2. decrease horizontal_rule width, e.g.: `$width -= 8`, to accommodate line numbers up to 4 digits. I added `-S`, but It should be fine to use either here.
We end up getting a lot of bug reports due to broken tput installations. This will wrapper tput and keep errors to a minimum
…into add-hg-to-protips
|
Everything I did made this worse. I'm going to open a clean PR and spend some time in the shame cube. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested on #186.
LMK if you want some style changes, or feel free to edit before merging.