SO1S-487 istio-sidecar-생성-방식-변경 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
DPS0340
requested changes
Oct 20, 2022
| String host = deployment.getEndPoint().toLowerCase(); | ||
|
|
||
| Deployment inferenceDeployment = new DeploymentBuilder() | ||
| .withNewMetadata() | ||
| .withName(deployName) | ||
| .withNamespace(namespace) | ||
| .addToLabels(labels) | ||
| .addToAnnotations(annotations) |
There was a problem hiding this comment.
Deployment 자체의 어노테이션이 아닌 WithNewTemplate 구문부터 시작되는 Pod에 대해 Annotation을 추가해주셔야 합니다~
|
@DPS0340 수정했습니다! 놓친 거 알려주셔서 고마워요 :) |
Analysis Details20 Issues
Coverage and Duplications
Project ID: So1S_backend_AYHrZkBbJVI_JANDYCcZ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
istio-sidecar-생성-방식-변경
Tasks
Discussion
Jira