Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SO1S-349 ALB / NLB 걷어내기 #28

Merged
merged 32 commits into from
Sep 1, 2022
Merged

SO1S-349 ALB / NLB 걷어내기 #28

merged 32 commits into from
Sep 1, 2022

Conversation

DPS0340
Copy link
Member

@DPS0340 DPS0340 commented Aug 31, 2022 •
edited
Loading

ALB / NLB 걷어내기

Tasks

  • LoadBalancer -> ClusterIP 타입으로 변경
  • Ingress 비활성화
  • Gateway 작성
  • VirtualService 작성
  • Istio OutOfSync 문제 해결
  • 작동 확인

Discussion

Jira

  • SO1S-349
  • SO1S-350
  • SO1S-351

NEM-NE
NEM-NE requested changes Sep 1, 2022
View reviewed changes
Copy link
Member

@NEM-NE NEM-NE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yaml 차트에 대해서 포맷팅을 다 같이 맞춰야될 거 같네요 이건 나중에 설정 공유를 해주시면 반영하겠습니다

targetRevision은 istio 차트를 제외한 나머지 main으로 맞춰 주시면 좋을 거 같습니다

추가적으로 정상 작동하는지도 알 수 있을까요?

apps/dev/app-backend.yaml Outdated Show resolved Hide resolved
apps/dev/app-istio-base.yaml Show resolved Hide resolved
charts/argocd/argocd-dev-values.yaml Outdated Show resolved Hide resolved
charts/backend/dev-values.yaml Outdated Show resolved Hide resolved
charts/backend/values.yaml Show resolved Hide resolved
charts/monitoring/templates/grafana/gateway.yaml Outdated Show resolved Hide resolved
charts/monitoring/templates/grafana/virtualservice.yaml Outdated Show resolved Hide resolved
root-dev.yaml Outdated Show resolved Hide resolved
root-dev.yaml Outdated Show resolved Hide resolved
shinilseop
shinilseop reviewed Sep 1, 2022
View reviewed changes
Copy link
Contributor

@shinilseop shinilseop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 깔끔하게 잘 바뀐것 같네요.
근데 이렇게 ALB, NLB를 모두 걷어내고 나서 인퍼런스 서버에 요청이 많이 들어왔을때
쿠버네티스 DNS에 부담이 많이 가지는 않나요 ?

클러스터 IP로 연결하면 다시 쿠버네티스 DNS를 타고 들어가지 않나해서 물어봅니다!

apps/dev/app-istio-base.yaml
Comment on lines 25 to +28
syncPolicy:
automated:
prune: true
selfHeal: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self Healing은 주기적으로 확인하고 정상적으로 작동되지 않았으면 재부팅하는건가요 ??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 거의 비슷한 작업으로 OutOfSync를 자동으로 해결해주는 역할입니다!

@DPS0340
Copy link
Member Author

DPS0340 commented Sep 1, 2022

@shinilseop 쿠버네티스 DNS는 kube-dns 기준으로 최대 수백개 규모를 다룰 수 있고, core-dns를 사용한다면 더 대규모를 다룰 수 있어서 문제 없을 것 같아요!

@DPS0340
Copy link
Member Author

DPS0340 commented Sep 1, 2022

@NEM-NE 수정사항 변경 및 Gateway 동작 확인 후 다시 알려드리겠습니다~

@NEM-NE NEM-NE closed this Sep 1, 2022
@NEM-NE NEM-NE reopened this Sep 1, 2022
@DPS0340
Copy link
Member Author

DPS0340 commented Sep 1, 2022 •
edited
Loading

@NEM-NE @shinilseop

Grafana, Backend 잘 동작합니다~
https://test-dashboard.so1s.io/
https://test-www.so1s.io/

Prometheus는 Redirection 에러가 뜨는데 도와주실 수 있으실까요~?
https://test-prom.so1s.io/graph

monitoring-kube-prometheus-prometheus 서비스와 연동했는데 이 서비스가 맞을까요?

targetRevision은 머지하기 직전에 모두 main으로 수정하겠습니다!

@DPS0340
Copy link
Member Author

DPS0340 commented Sep 1, 2022

Prometheus는 Redirection 에러가 뜨는데 도와주실 수 있으실까요~? https://test-prom.so1s.io/graph

monitoring-kube-prometheus-prometheus 서비스와 연동했는데 이 서비스가 맞을까요?

서비스 연동 성공했습니다!

NEM-NE
NEM-NE approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@NEM-NE NEM-NE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@NEM-NE NEM-NE merged commit b3e73e2 into main Sep 1, 2022
@DPS0340 DPS0340 deleted the SO1S-349-deploy-alb-nlb-걷어내기 branch December 6, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinilseop shinilseop shinilseop left review comments

@NEM-NE NEM-NE NEM-NE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DPS0340 @NEM-NE @shinilseop