Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SO1S-363 terraform dev 환경 자동화 istio ingress 오류 #32

Merged
merged 4 commits into from
Sep 7, 2022
Merged

SO1S-363 terraform dev 환경 자동화 istio ingress 오류 #32

merged 4 commits into from
Sep 7, 2022

Conversation

NEM-NE
Copy link
Member

@NEM-NE NEM-NE commented Sep 6, 2022

terraform dev 환경 자동화 istio ingress 오류

dev 환경 argocd 어플리케이션 프로비저닝 과정 중 istio ingress는 AWS 환경을 유지한 채로 생성됨

Tasks

  • ingress enabled 설정 생성
  • vender, environment 설정 키 생성
  • prod, dev yaml에 적용
  • ingress 리팩토링

Discussion

  • environment가 dev일 경우에도 ingress를 사용할 여지가 있다고 생각하여 ingress.enabled 만으로 ingress 생성 여부를 끌 수 있도록 설정 했습니다.

Jira

  • SO1S-363

@NEM-NE NEM-NE added the Refactoring 코드를 개선 및 정리했습니다. label Sep 6, 2022
@NEM-NE NEM-NE requested a review from DPS0340 September 6, 2022 13:41
@NEM-NE NEM-NE self-assigned this Sep 6, 2022
DPS0340
DPS0340 approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@DPS0340 DPS0340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ 👍

shinilseop
shinilseop approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@shinilseop shinilseop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 👍

@NEM-NE NEM-NE merged commit 3c72b0d into main Sep 7, 2022
@NEM-NE NEM-NE deleted the SO1S-363-infra-terraform-dev-환경-자동화-istio-ingress-오류 branch October 19, 2022 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinilseop shinilseop shinilseop approved these changes

@DPS0340 DPS0340 DPS0340 approved these changes

Assignees

@NEM-NE NEM-NE

Labels
Refactoring 코드를 개선 및 정리했습니다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NEM-NE @DPS0340 @shinilseop