Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NEM-NE
approved these changes
Jul 20, 2022
charts/gateway/README.md
Outdated
| @@ -0,0 +1,148 @@ | |||
| # Istio Gateway Helm Chart | |||
charts/gateway/values.schema.json
Outdated
Comment on lines
179
to
181
| "tolerations": { | ||
| "type": "array" | ||
| }, |
There was a problem hiding this comment.
나중에 커스텀 values.yaml 부분 작성하실 때 api노드로만 스케줄링 되도록 설정해주세요!
charts/istio-base/README.md
Outdated
| @@ -0,0 +1,21 @@ | |||
| # Istio base Helm Chart | |||
charts/gateway/values.yaml
Outdated
Comment on lines
59
to
65
| resources: | ||
| requests: | ||
| cpu: 100m | ||
| memory: 128Mi | ||
| limits: | ||
| cpu: 2000m | ||
| memory: 1024Mi |
There was a problem hiding this comment.
istio도 전체적으로 리소스를 얼마나 잡아먹을까요? 과부하가 발생할 일이 생길까요?
왜 불안하게 게이트웨이 limit을 저렇게 높게 잡을까요 🧐
There was a problem hiding this comment.
api gateway가 모든 외부 리퀘스트가 한번씩 거쳐가기 때문에 어느정도 limit가 높을 필요가 있을 것 같아요!
charts/istiod/README.md
Outdated
| @@ -0,0 +1,59 @@ | |||
| # Istiod Helm Chart | |||
Comment on lines
68
to
70
| {{- with .Values.pilot.tolerations }} | ||
| tolerations: | ||
| {{- toYaml . | nindent 8 }} |
There was a problem hiding this comment.
넵!! 기존 차트 레퍼런스로 반영하겠습니다!
|
고생하셨습니다!! |
|
@NEM-NE 수정사항 반영하였습니다! 확인해 주세요~~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Istio 구성
Tasks
Discussion
Jira