Add support for shared configuration via Azure #250
Conversation
Add Implementation-Version to Manifest so that it shows in the UI and set exhibitor version to be the same as the exhibitor-standalone dependency version.
|
I'd like to see this in a separate module so that the core doesn't have to be burdened with the deps and code. Something like exhibitor-azure. |
| @@ -21,6 +21,7 @@ | |||
| import com.google.common.collect.Iterables; | |||
| import com.google.common.collect.Lists; | |||
| import com.netflix.exhibitor.core.Exhibitor; | |||
| import com.netflix.exhibitor.core.azure.PropertyBasedAzureCredential; | |||
There was a problem hiding this comment.
If Azure is in a separate module, we'll need some way to inject azure support here.
|
Exhibitor is currently AWS-only, right? Having it inherently support multiple cloud providers in the main package seems like a boon. An exhibitor-azure module would include both AWS and Azure, which seems odd. |
|
Actually, it's not AWS only though it has an "aws-accent". It might be good to pull all the provider stuff out so that people can pick and choose. |
|
Exhibitor already supports multiple ways to form the cluster (NFS, S3, ZK). However, S3 is already part of core. Perhaps decoupling these as separate modules should be the concerns of another issue? I don't need Azure, however I don't think a contribution that could be valuable to many users should be blocked for months by a module layout decision. |
|
FYI - I'm in discussion with Netflix to move Exhibitor to its own repo so that it get better community support. Please stayed tuned. |
|
Can this be merged now it's in its own repo? |
This PR enables Exhibitor to use Azure's Blob Storage service for shared configuration and automatic instance management.
I mostly followed the pattern set by the S3 ConfigProvider. I'm not much of a Java guy, so please let me know if you'd like changes (stylistic, idiomatic, or otherwise) before merging.