Skip to content
This repository has been archived by the owner on Apr 23, 2020. It is now read-only.

Add support for pluggable S3CredentialProviders #314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for pluggable S3CredentialProviders #314

wants to merge 1 commit into from

Conversation

kipz
Copy link

@kipz kipz commented Oct 4, 2016

Core support for this is in Exhibitor already, so this PR just exposes it to the CLI.

  • Added --s3credsproviderclass CLI option (mutually exclusive with --s3credentials)
  • Moved current property based configuration to a new PropertyBasedS3CredentialsProvider for symmetry

The implementation o S3CredentialsSupplier is created by calling no-args constructor.

I need this so that:

  • Credentials are not stored unencrypted on disk
  • Credentials can be cycled regularly without restarting Exhibitor and therefore Zookeeper

It might be nice in the future to support hot reloading for the properties-file based configuration method, but this should be easier now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant