Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to support the new llama.cpp and fix executor bug #155

Merged
merged 2 commits into from
Jun 10, 2023
Merged

Update to support the new llama.cpp and fix executor bug #155

merged 2 commits into from
Jun 10, 2023

Conversation

cometyang
Copy link
Contributor

update code for ggml-org/llama.cpp#1509 and fix executor.

@williamhogman
Copy link
Contributor

williamhogman commented Jun 10, 2023 •
edited
Loading

Thanks for the help with this one!

Could you run cargo fmt so it passes the lint :)

williamhogman
williamhogman approved these changes Jun 10, 2023
View reviewed changes
Copy link
Contributor

@williamhogman williamhogman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cometyang
Copy link
Contributor Author

i run "cargo fmt", now it should have no format issue.

@williamhogman
Copy link
Contributor

Still some problem with the example but will merge and fix in main instead.

@williamhogman williamhogman merged commit a9fb35c into sobelio:main Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamhogman williamhogman williamhogman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cometyang @williamhogman