avoid passing passphrase using shell, because it is non-optimal

[joshrabinowitz]

in src/_utils/_git_secret_tools.sh we pass the passphrase to gnupg using 'echo', which means it could be visible to other users using ps. Can we improve this situation?
See https://github.com/sobolevn/git-secret/blob/master/src/_utils/_git_secret_tools.sh#L815

EDIT: this has been fixed to use a more secure method

[joshrabinowitz]

Ditto for passing passphrase on command line to 'reveal' and 'cat', can we provide/document another way?
See
https://github.com/sobolevn/git-secret/blob/master/src/commands/git_secret_reveal.sh#L25
and
https://github.com/sobolevn/git-secret/blob/master/src/commands/git_secret_cat.sh#L14
(Edit: fixed links)

[joshrabinowitz]

Can we use --passphrase-fd or --passphrase-file as described on page 83 of https://gnupg.org/documentation/manuals/gnupg.pdf ?
See also
https://superuser.com/questions/1357208/decrypt-and-encrypt-a-file-using-gpg-without-re-typing-the-passphrase

Edit:
Also see: https://unix.stackexchange.com/questions/29111/safe-way-to-pass-password-for-1-programs-in-bash/29186#29186

[sobolevn]

This looks like a more secure approach, 100%

[joshrabinowitz]

ok, we now use a file descriptor to pass the passphrase from git-secret to gnupg.

I think all that remains of this ticket is to discourage people from using the -p PASSPHRASE option of reveal and cat where possible, and document the alternatives.