timeline segments shouldn't process items if they overlap with the re…

…corder's zone of responsibility #11
sobri909 · May 29, 2018 · 2d65a0b · 2d65a0b
1 parent 82a2a8e
commit 2d65a0b
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/LocoKit/LocalStore/TimelineSegment.swift b/LocoKit/LocalStore/TimelineSegment.swift
@@ -132,9 +132,13 @@ public class TimelineSegment: TransactionObserver {
     }
 
     private func process() {
-        if let items = timelineItems {
-            TimelineProcessor.process(items)
-        }
+        guard let items = timelineItems else { return }
+
+        // shouldn't do processing if currentItem is in the segment and isn't a keeper
+        // (the TimelineRecorder should be the sole authority on processing those cases)
+        for item in items { if item.isCurrentItem && !item.isWorthKeeping { return } }
+
+        TimelineProcessor.process(items)
     }
 
     // MARK: - TransactionObserver