tweaking tests

sobstel · Feb 24, 2024 · fb003b3 · fb003b3
1 parent 2dd22bb
commit fb003b3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -10,11 +10,6 @@ jobs:
       - uses: supercharge/redis-github-action@1.4.0
       - uses: actions/checkout@v2
       - uses: php-actions/composer@v5
-      - name: phpunit (php latest)
-        uses: php-actions/phpunit@v3
-        with:
-          configuration: ./phpunit.xml
-          php_extensions: memcache memcached
       - name: phpunit (php 7.4)
         uses: php-actions/phpunit@v3
         with:
@@ -45,3 +40,9 @@ jobs:
           configuration: ./phpunit.xml
           php_extensions: memcache memcached
           php_version: 8.3
+      - name: phpunit (php latest)
+        uses: php-actions/phpunit@v3
+        with:
+          configuration: ./phpunit.xml
+          php_extensions: memcache memcached
+          php_version: latest
diff --git a/tests/src/CacheTest.php b/tests/src/CacheTest.php
@@ -26,8 +26,8 @@ public function testServesStaleValueIfOtherProcessIsGeneratingContent()
         $key = "masche14";
 
         $lockManagerMock = $this->createLockManagerMock();
-        $lockManagerMock->method('acquire')->with($this->equalTo($key))->will($this->returnValue(true));
-        $lockManagerMock->method('release')->with($this->equalTo($key))->will($this->returnValue(true));
+        $lockManagerMock->method('acquire')->with($this->equalTo($key))->willReturn(true);
+        $lockManagerMock->method('release')->with($this->equalTo($key))->willReturn(true);
 
         $cache = new Cache(new MockStore, $lockManagerMock);