Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade VerticalTextView to alternative version #14

Merged
merged 1 commit into from
Apr 4, 2016

Conversation

michalbednarski
Copy link
Contributor

Use alternative version provided on http://stackoverflow.com/a/7855852
(where original VerticalTextView appears to come from too)

Original version had problems, such as clipping text incorrectly,
leaving for example just "CK" instead of "BACK"

Use alternative version provided on http://stackoverflow.com/a/7855852
(where original VerticalTextView appears to come from too)

Original version had problems, such as clipping text incorrectly,
leaving for example just "CK" instead of "BACK"
@sockeqwe
Copy link
Owner

Thanks, I will take a look in the next days

@Ericmas001
Copy link

I ended up removing the text on my layout to get rid of the "ck" problem! It would be a nice update :)

@sockeqwe
Copy link
Owner

sockeqwe commented Apr 4, 2016

@michalbednarski I'm not able to reproduce the "clipping text incorrectly" problem. On which device have you seen this problem?
Did that new VerticalTextView solve that problem on your testing device?

@Ericmas001
Copy link

The problem happens on my nexus 6, stock os!

@michalbednarski
Copy link
Contributor Author

Also Nexus 7 with Android 6.0.1, screenshot:
Just CK instead of BACK

On Android 6.0 emulator from SDK, the glitch can be seen other way, when partially swiped only CK is dimmed:
CK dimmed in BACK

@sockeqwe
Copy link
Owner

sockeqwe commented Apr 4, 2016

Hm, interesting, I have the same Nexus 6 and can't reproduce the issue. I will merge your pull request! Please inform me if this error still occurred with the new VerticalTextView implementation

@sockeqwe sockeqwe merged commit 2c15c4b into sockeqwe:master Apr 4, 2016
@michalbednarski
Copy link
Contributor Author

It's working for me now, maybe @Ericmas001 could also check and confirm.

I'm using currently snapshot version with aar included in my app repository. (Here's diff with this setup).

Could we get this change pushed into Maven Central?

@sockeqwe
Copy link
Owner

sockeqwe commented Apr 5, 2016

I have released 1.0.3 containing the new VerticalTextView

@Ericmas001
Copy link

It's working for me too ! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants