Add option to share OkHttpClient #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@unchosen Thanks so much for making the pul request? Would it be possible for you to please update the test case that's failing? |
|
Odd.. In the first Travis CI tests ran on this PR, openjdk7 tests completed, yet the openjdk8 tests failed on the yeast test. |
b95505017
reviewed
Apr 23, 2017
| @@ -148,6 +151,7 @@ protected void onClose() { | |||
|
|
|||
| public static class Options { | |||
|
|
|||
| public storeOkHttpClient storeOkHttpClient = null; | |||
There was a problem hiding this comment.
I think that use WebSocket.Factory interface is enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially Fixes Issue #81
This adds an option to share an OkHttpClient instance over multiple sockets (from reconnect attempts, and etc). Defaults to false.
Let me know if the option can be named better, or if this can be done a better way.
This java-client-specific option can probably be mentioned in the readme under features?