Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Revert "default rejectUnauthorized to true" #496

Merged
merged 1 commit into from
Oct 5, 2016

Conversation

darrachequesne
Copy link
Member

This reverts commit 2c55b27, which breaks websocket transport under node v0.10 (#494).

This reverts commit 2c55b27, which breaks websocket transport under node v0.10 (socketio#494).
@darrachequesne darrachequesne merged commit 67ac4b7 into socketio:master Oct 5, 2016
@darrachequesne darrachequesne deleted the patch-1 branch October 5, 2016 05:12
@Nibbler999
Copy link

The original commit was a security fix, not sure reverting it is wise.

@darrachequesne
Copy link
Member Author

@Nibbler999 thanks for the heads up! Support for node v0.10 will be dropped in next release.

@andrew-aladev
Copy link

andrew-aladev commented Dec 16, 2016

@Nibbler999 You can simply fix this issue by adding a validation of agent on the node v0.10 side. If agent is null than rejectUnauthorized need to be null. Websockets will work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants