Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents a potential ReDoS. See here: https://nodesecurity.io/advisories/528
I couldn't find any benefits to using parsejson; It seems to just call JSON.parse if it exists, and it exists in every node version, and every browser released since 2008.
Should I run the
make
and include it in this PR, or is that done by a build server or something along those lines?The kind of change this PR does introduce
Current behaviour
Potential ReDoS for large strings due to
parsejson
package.New behaviour
Removes
parsejson
in favour of native parsing.Other information (e.g. related issues)
Reported here: #579