try/catch xhr.responseType to avoid exception #590
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line can cause exceptions on Android 4.x in certain circumstances.
Unfortunately, not reproducible but only visible when logging client errors in production, see #589
Note: the
engine.io.js
file is the generated output ofmake engine.io.js
, and should not be manually modified.The kind of change this PR does introduce
Current behaviour
When logging the JS errors our clients experience, we see quite some significant numbers of
INVALID_STATE_ERR: DOM Exception 11
in chrome on android 4.x and some opera browsers. It is not reproducible, though.
New behaviour
When putting the line in a try/catch, no more errors are logged AND there a no NEW ones, so it looks like it is improving the experience.
Other information (e.g. related issues)
#589