Encode string payloads as strings even if binary supported #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 44c7aa5, which caused string payloads to be encoded as binary (so that huge string payloads were needlessly UTF-8-encoded).
darrachequesne
added a commit
to darrachequesne/engine.io-parser
that referenced
this pull request
Mar 21, 2017
That will allow clients receiving the xhr payload with responseType = 'arraybuffer' to properly decode the message, which is not sent as binary by the backend anymore since 292c00c (socketio#85).
darrachequesne
added a commit
that referenced
this pull request
Mar 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 44c7aa5, which caused string payloads to be encoded as binary (so that huge string payloads were needlessly UTF-8-encoded).
Related: socketio/socket.io#2872