Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientsCount property of server... why need to keep this private, #672

Closed
devashishg opened this issue Feb 23, 2023 · 1 comment · Fixed by #675
Closed

clientsCount property of server... why need to keep this private, #672

devashishg opened this issue Feb 23, 2023 · 1 comment · Fixed by #675
Labels
enhancement New feature or request

Comments

@devashishg
Copy link

private clientsCount: number;

Prior to migration it was accessible form server's engine property, but now this is made private and though the count is being updated but never getting used.
Can we get back to keeping this public property of Abstract class BaseServer.

@darrachequesne
Copy link
Member

Hi! You are right, the clientsCount has been made private during the migration to TypeScript, but this is not really needed. Let's change this 👍

@darrachequesne darrachequesne added the enhancement New feature or request label Feb 23, 2023
tyilo added a commit to tyilo/engine.io that referenced this issue Apr 19, 2023
@tyilo tyilo mentioned this issue Apr 19, 2023
5 tasks
darrachequesne pushed a commit that referenced this issue Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants