Adopt a stream interface for the socket instance

[3rd-Eden]

Consider implementing a stream compatible interface on top of the socket. It is already inherting from EventEmitter so making it a writeable, and readable Stream (http://nodejs.org/api/stream.html) would be a small but potentially important step as it would allow us to write pipe-able interfaces on top of engine.io.

[rauchg]

Yes

[owenb]

Hey Arnout

I recall you tweeting about this last week. Has the code made it into master yet, or were you proposing an API?

It would be great to have this.

[3rd-Eden]

@owenb I worked on this in my stream branch: https://github.com/3rd-Eden/engine.io/tree/stream. The only that my small test reached 100% cpu and started leaking memory.. So I'm still debugging it, but it's coming. I hope that i can finish it before realtime conf starts ;p

[owenb]

Great news :) I will hopefully be able to try out your branch before NodeDublin. Thanks!

[juliangruber]

@3rd-Eden maybe have a look at https://github.com/substack/shoe for a working implementation based on sockjs which should be easy to adapt

[3rd-Eden]

@juliangruber it's already working, just need to find time to add tests to it.. See https://github.com/3rd-Eden/engine.io/tree/stream

[juliangruber]

https://github.com/dominictarr/stream-spec

[juliangruber]

@3rd-Eden I see it still emits 'message' instead of 'data'. So you won't be able to pipe!

[3rd-Eden]

@juliangruber That is correct, because it's a writeable stream

[juliangruber]

In your code the stream is readable...and why not make it emit message and data?

[3rd-Eden]

@juliangruber would work i guess

[juliangruber]

Hm I don't really get why you would implement only half of the stream interface, what is the win?

[Raynos]

100% Node.JS core style

You can't claim to use node.js core style if it's not a stream.

[Raynos]

https://github.com/Raynos/engine.io-stream

Feel free to port or inline that into engine.io. Or tell people that want a stream to just use that.