[fix] workaround for setEncoding bug on node 0.10+ #527
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
engine.io often crashes with an error
this is caused by a bug in new versions of node, where setEncoding call does not work for messages that are already in the queue
The following code snippet
in node 0.10 prints
and in newer versions of node prints
this pull request makes sure that concat is never called in the non binary case, even if setEncoding does not work properly.
This is related to #305, which have fixed a part of the issue.