fix: improve compat with ts in node16/bundler mode #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when using the newer resolution and module modes of typescript, it could pick up `./wrapper.mjs`, which does not have a `.d.ts` file next to it. added the `"types"` condition to ensure imports to `"engine.io"` always get a type, no matter if they are sourced in commonjs or esm.
|
@AviVahl thanks 👍 |
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the newer resolution and module modes of typescript, it could pick up
./wrapper.mjs, which does not have a.d.tsfile next to it.Added the
"types"condition to ensure imports to"engine.io"always get a type, no matter if they are sourced in commonjs or esm.The kind of change this PR does introduce
Current behaviour
Cannot find types for package in these newer modes.
New behaviour
Works as expected. Types load.
Other information (e.g. related issues)
Change is backward compatible.