Bump minimum deployment target to iOS 12 to match Starscream dependency #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is an error when compiling for release: ``` Compiling for iOS 11.0, but module 'Starscream' has a minimum deployment target of iOS 12.0 ``` This pull request addresses this error by bumping the minimum deployment target to match Starscream.
|
Facing same issue. |
|
@nuclearace Could you kindly provide an update on when you plan to merge changes into the master branch? We're currently unable to proceed with the new version due to this conflict. |
|
Just following up as well to get an ETA on this @nuclearace? |
|
@nuclearace I got the same issue when trying to push my iOS module to Cocoapods, Could you please let me know when you will merge this fix to the master branch? |
|
It is apparent this will not be attended to anytime soon. Anyone still having this issue I managed to fix it by fixing the Startscream version on the podspec to the last known working version s.dependency 'Starscream', '4.0.6'
s.dependency 'Socket.IO-Client-Swift', '~> 16.1.0' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is an error when compiling for release:
This pull request addresses this error by bumping the minimum deployment target to match Starscream.