Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minified version breaks IE 8 #1040

Closed
1 of 2 tasks
johanneswuerbach opened this issue Dec 2, 2016 · 3 comments
Closed
1 of 2 tasks

Minified version breaks IE 8 #1040

johanneswuerbach opened this issue Dec 2, 2016 · 3 comments

Comments

@johanneswuerbach
Copy link

You want to:

  • report a bug
  • request a feature

Current behaviour

Parsing socket.io.js fails in IE 8 with Expect identifier, string or number

Steps to reproduce (if the current behaviour is a bug)

Test the minified version in IE 8

Expected behaviour

socket.io.js works in IE 8

Other information (e.g. stacktraces, related issues, suggestions how to fix)

The issue doesn't happen in socket.io 1.6 and also not on the non-minified version of 1.7.1.
johanneswuerbach added a commit to johanneswuerbach/testem that referenced this issue Dec 2, 2016
@johanneswuerbach
Pin socket.io
b6b2220 
socket.io >= 1.7.0 breaks IE 8, pin socket.io until
socketio/socket.io-client#1040 is resolved.
@johanneswuerbach johanneswuerbach mentioned this issue Dec 2, 2016
Merged
@johanneswuerbach
Copy link
Author

An ok solution for my use-case https://github.com/testem/testem, would also be to just have an option to serve the unminifyed version.

@darrachequesne
Copy link
Member

Related: mishoo/UglifyJS#1179

This was referenced Dec 8, 2016
Merged
Closed
@darrachequesne darrachequesne mentioned this issue Feb 1, 2017
Closed
2 tasks
@darrachequesne
Copy link
Member

Closed by #1042.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johanneswuerbach @darrachequesne