-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
socket.io-parser library upgrade from v4.2.0 to v4.2.1 #1559
Conversation
@darrachequesne Please Review this Pull Request |
@rauchg @3rd-Eden @nkzawa @zweihan @kevin-roark Please Review this PR |
@Annniee1 the version does not exist, could you please check? |
@darrachequesne Thanks for your quick response. I have Edited my files. Can you please Review it once again |
@darrachequesne Please have a look at the changed files Once. |
Merged as cedd311. Thanks 👍 |
Thanks @darrachequesne for bumping socket.io-client. When can we expect this to published to npm? |
@darrachequesne Are we bumping the version for socket.io-client after this bump of socket.io-parser and publishing to npm |
@vinodkumarsharma276 @Annniee1 |
Note: the
socket.io.js
file is the generated output ofmake socket.io.js
, and should not be manually modified.The kind of change this PR does introduce
Current behaviour
New behaviour
Other information (e.g. related issues)