Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socket.io-parser library upgrade from v4.2.0 to v4.2.1 #1559

Closed
wants to merge 2 commits into from

Conversation

Annniee1
Copy link
Contributor

@Annniee1 Annniee1 commented Nov 2, 2022

Note: the socket.io.js file is the generated output of make socket.io.js, and should not be manually modified.

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

New behaviour

Other information (e.g. related issues)

@Annniee1
Copy link
Contributor Author

Annniee1 commented Nov 2, 2022

@darrachequesne Please Review this Pull Request

@Annniee1
Copy link
Contributor Author

Annniee1 commented Nov 2, 2022

@rauchg @3rd-Eden @nkzawa @zweihan @kevin-roark Please Review this PR

@darrachequesne
Copy link
Member

@Annniee1 the version does not exist, could you please check?

@Annniee1 Annniee1 closed this Nov 2, 2022
@Annniee1 Annniee1 reopened this Nov 2, 2022
@Annniee1 Annniee1 changed the title socket.io-parser library upgrade from v4.2.0 to v4.5.0 socket.io-parser library upgrade from v4.2.0 to v4.2.1 Nov 2, 2022
@Annniee1
Copy link
Contributor Author

Annniee1 commented Nov 2, 2022

@darrachequesne Thanks for your quick response. I have Edited my files. Can you please Review it once again

@Annniee1
Copy link
Contributor Author

Annniee1 commented Nov 3, 2022

@darrachequesne Please have a look at the changed files Once.

@darrachequesne
Copy link
Member

Merged as cedd311. Thanks 👍

@vinodkumarsharma276
Copy link

Thanks @darrachequesne for bumping socket.io-client. When can we expect this to published to npm?

@Annniee1
Copy link
Contributor Author

Annniee1 commented Nov 7, 2022

@darrachequesne Are we bumping the version for socket.io-client after this bump of socket.io-parser and publishing to npm

@darrachequesne
Copy link
Member

darrachequesne commented Nov 7, 2022

@vinodkumarsharma276 @Annniee1 socket.io-client@4.5.3 uses socket.io-parser@~4.2.0, so running npm audit fix or npm update socket.io-parser should be sufficient I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants