Catch exceptions thrown by WebSocket constructor #980
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My browser (Google Chrome 51.0.2704.84 (64-bit) Linux) throws net::ERR_NAME_RESOLUTION_FAILED when calling new WebSocket with no Internet connection available. The uncaught exception breaks socket.io's reconnection attempts. This patch solves the problem.
|
I see Travis CI failing for iphone/6.1 and iphone/latest. Should I fork from a previous socket.io-client version, add my changes and try again? |
|
@matonga thanks for the PR! The fix has been applied here: socketio/engine.io-client#475 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My browser (Google Chrome 51.0.2704.84 (64-bit) Linux) throws net::ERR_NAME_RESOLUTION_FAILED when calling new WebSocket with no Internet connection available. The uncaught exception breaks socket.io's reconnection attempts. This patch solves the problem.