Refactored Listener#broadcast()

might be better off to chekc arguments.length and ignore the check within the loop all together for those cases
socketio · Apr 21, 2011 · 64a081f · 64a081f · ronkorving · Apr 26, 2011
1 parent 048eeec
commit 64a081f
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/socket.io/listener.js b/lib/socket.io/listener.js
@@ -100,11 +100,13 @@ Listener.prototype.broadcast = function(message, except){
 
   for (var i = 0; i < len; ++i){
     key = keys[i];
-    if (!except || ((typeof except == 'number' || typeof except == 'string') && key != except)
-                || (Array.isArray(except) && except.indexOf(key) == -1)){
-      this.clients[key].send(message);
+    if (except) {
+      if (Array.isArray(except) && ~except.indexOf(key)) continue;
+      else if (key == except) continue;
     }
+    this.clients[key].send(message);
   }
+
   return this;
 };