-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't install on Windows with Node 0.12 #2056
Comments
it looks like my report #2057 is the same. |
@fibric yes, it looks like it is. |
Open issue socketio/engine.io-client#376, the error is from an ealier ws version; being fixed in engine.io-client |
Facing the same issue on windows 7 x64 with node 0.12. Errors reported on cmd.
|
I have the same problem with the vs2013 and node 0.12 |
I have same issue windows 8.1 and node 0.12.2 ok, ws compiles, but at version 0.7.1 (at version 0.5.0 too):
engine.io compiles, notice different ws version 0.5.0:
with engine.io there seems to be an issue... The master branch here specifies 1.5.1 with ws 0.7.1, but the npm module references 0.5.0 at version 1.5.1 of engine.io. Not show stopping, but an issue. socket.io version 1.3.5 has issues compiling:
socket.io-client (1.3.5) has an issue compiling (ws@0.4.31):
engine.io-client (1.5.1) has an issue compiling (ws@0.4.31):
so it seems socket.io, socket.io-client, engine.io-client need to be updated and sails-hook-sockets reference them. ws versions need to be updated t be the same. Currently there are three different ones being referenced: |
I was able to fix the compiling by forking the repos and referencing the correct versions of everything in the package.json. So, the npm packages need to be updated with the correct version references to fix this. socket.io, engin.io-client, socket.io-client compiles:
|
except for engine.io, all of socket.io is failing compile on win 8.1. (engine.io-client, socket.io-client, socket.io) the fix was to reference all the correct modules in package.json. I tested in forks. |
Bump... |
Also causes a lot of errors when Karma is installed, for the same reasons given. It seems there is inconsistent references to the WS package in socket.io-client and engine.io, which leads to build errors. As others have noted, updating to use 0.7.x seems to fix the problems. |
Workaround: |
@einfallstoll the problem is more about installing webpack-dev-server or karma or browsersync or or or solution right now on windows machines is to find those compile errors, navigate to each package folder where ws has failed and install newest ws version manually. |
@fibric this no problem. Just do |
@fibric the reason this will work are two mechanisms: npm: npm won't install a required module if its already included in the parents node.js: node.js will search the file system tree, until it finds the module. If Because of this, installing |
This is great, unless you use a framework like sails that gets installed globally then uses generators to create projects.. we need socket.io fixed |
@Karnith I don't know sails, but it would generate a regular node.js project where you can manually include |
@fibric is correct, the problem comes into play with global modules. Got it fixed on my machine by forking the whole socket.io hierarchy and browser-sync and updating the ws references at the bottom of the chain. Feel free to use these forks until they update the versions on npm - |
As I mentioned in #2114 the npm algorithm works different for global and local modules. Because of this my workaround won't compile globally. |
@einfallstoll Is correct. You can fork and update all the packages or |
Its not only browser-sync. Its also required by grunt-contrib-connect and grunt-contrib-watch for its livereload. Two much used plugins. Especially in tutorials and examples which will now fail if you haven't already got a version that works. Not sure if Gulp has similar issues. Also one that now fails: PhantomJS, which is used for testing various frameworks and thus will make many fail (like many Angular-related projects). I tried installing some personal projects today and noticed the socket.io dependency fails, which results in my grunt not serving properly (hangs while watching but won't serve files). It will also fail on installation many times. If the fixes are rolled out, i can then submit issues for other projects to update their dependencies. Until then its not really a solution for many projects to temporarily hack your fix in. Since they are dependencies (of dependencies) Any ETA on when it will be rolled out? |
@Martinspire - I haven't seen anything regarding timeline. I submitted the package.json workaround as pull request for browser-sync but it may not get rolled in due to this being a socket.io issue. Short term solution is to use the solution prescribed by @einfallstoll to fork each of the top level projects (grunt-contrib-connect, grunt-contrib-watch, etc.) and add the following package.json modifications - { "dependencies": {
"engine.io": "automattic/engine.io#860af4dc0b47e55a623e7e56ce097ba4b610264b",
"engine.io-client": "automattic/engine.io-client#cffcc899546d451e53f7d8e8a309272f95099148",
"socket.io-client": "automattic/socket.io-client#e898166382f7a811cf0e1b07b53ddb61b43b238a",
"socket.io": "^1.3.5"
} } With these mods, it will use the latest version of those libraries which point to the correct ws package. |
+1 paging @rauchg |
Fixing this asap |
Any idea when this will be fixed? Still getting it (although the workaround will do for now). |
This is still an issue.... |
Installing automattic/engine.io-client first worked for me a few days ago but is not working any more. For some reason I thought something had been updated so I got rid of it and installed socket.io by it's self. Now the solution above won't work anymore. I deleted both engine.io and socket.io from node_modules, removed the entries in package.json and tried using the npm cache clean command (maybe I don't know how to use it) but either way it now seems like the wrong version of engine.io is cached somewhere or something. I even manually deleted the npm_cache directory and still above solution is not working any more |
Should be fixed! |
👍 Works for me! |
confirmed working here on win 7 64 bit node v0.12.7. socket.io 1.3.6 Thanks |
Yep! |
I still have problems with browser-sync BrowserSync/browser-sync#728 |
npm install socket.io
fails brutally on Windows 8.1 and 7 with Node 0.12, returning errors such as:Same Node version on Mac OS gives no error at all.
Build tools: Microsoft Visual Studio 2013.
Full log: https://gist.github.com/frapontillo/e3416bccb5c3cffb4339
The text was updated successfully, but these errors were encountered: