Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support an arbitrary query string (cache buster) when serving the client JavaScript #4023

Closed
TimWolla opened this issue Jul 17, 2021 · 0 comments · Fixed by #4024
Closed
Labels
enhancement New feature or request
Milestone

Comments

@TimWolla
Copy link
Contributor

Is your feature request related to a problem? Please describe.

My AMD module loader automatically adds a ?t=<timestamp> query string to loaded modules as a cache buster. This query string causes the client serving to fail, returning a JSON with message: transport unknown.

Describe the solution you'd like

I'd like that the detection of requests for the client JS ignores the query string.

Describe alternatives you've considered

I could serve the client manually, but this might cause the versions of the server and client to diverge. I could also strip the query string using a reverse proxy, but this creates additional moving parts where none should be.

Additional context

n/a

@TimWolla TimWolla added the enhancement New feature or request label Jul 17, 2021
@TimWolla TimWolla changed the title Support an arbitrary query string when serving the client JavaScript Support an arbitrary query string (cache buster) when serving the client JavaScript Jul 17, 2021
@darrachequesne darrachequesne added this to the 4.2.0 milestone Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants