Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for IE8 "Stack Overflow" Error. #458

Closed
firejune opened this issue Aug 10, 2011 · 6 comments
Closed

Fix for IE8 "Stack Overflow" Error. #458

firejune opened this issue Aug 10, 2011 · 6 comments
Labels
bug Something isn't working

Comments

@firejune
Copy link

in socket.io.js(ver 0.7.5) line 3085:

  XHR.prototype.request = function (method) {
    var req = io.util.request(this.socket.isXDomain())
      , query = io.util.query(this.socket.options.query, + 't=' + +new Date);

to:

  XHR.prototype.request = function (method) {
    var req = io.util.request(this.socket.isXDomain())
      , query = io.util.query(this.socket.options.query, 't=' + +new Date);

boom!

@denisu
Copy link

denisu commented Aug 11, 2011

Awesome, it works. Thank you! ㅋㅋ

@3rd-Eden
Copy link
Contributor

O_o that is one odd bug thats for finding it!

@JohnMcLear
Copy link

Worked for us with Etherpad Lite, thanks! :)

@JohnMcLear
Copy link

@3rd-Eden Is this bug closed and updated in the latest version? It's important for us :) Thanks!

@denisu
Copy link

denisu commented Aug 15, 2011

Yes its fixed in 0.7.9.

@rauchg
Copy link
Contributor

rauchg commented Sep 3, 2011

This was already fixed

@rauchg rauchg closed this as completed Sep 3, 2011
darrachequesne pushed a commit that referenced this issue Jul 4, 2024
darrachequesne pushed a commit that referenced this issue Jul 4, 2024
darrachequesne pushed a commit that referenced this issue Jul 4, 2024
Fixed removeAllListeners to behave expected
darrachequesne pushed a commit that referenced this issue Jul 8, 2024
darrachequesne added a commit that referenced this issue Jul 8, 2024
When the `verify` method fails, the current implementation closes the
connection immediately, which is understood by some proxy (such as
nginx) as if the server was not available (resulting in "upstream
prematurely closed connection while reading response header from
upstream" error). That commit make sure a proper response is sent
before closing the connection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants