-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for IE8 "Stack Overflow" Error. #458
Labels
bug
Something isn't working
Comments
Awesome, it works. Thank you! ㅋㅋ |
O_o that is one odd bug thats for finding it! |
Worked for us with Etherpad Lite, thanks! :) |
@3rd-Eden Is this bug closed and updated in the latest version? It's important for us :) Thanks! |
Yes its fixed in 0.7.9. |
This was already fixed |
darrachequesne
pushed a commit
that referenced
this issue
Jul 4, 2024
darrachequesne
pushed a commit
that referenced
this issue
Jul 4, 2024
Fixed removeAllListeners to behave expected
darrachequesne
pushed a commit
that referenced
this issue
Jul 8, 2024
darrachequesne
added a commit
that referenced
this issue
Jul 8, 2024
When the `verify` method fails, the current implementation closes the connection immediately, which is understood by some proxy (such as nginx) as if the server was not available (resulting in "upstream prematurely closed connection while reading response header from upstream" error). That commit make sure a proper response is sent before closing the connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
in socket.io.js(ver 0.7.5) line 3085:
to:
boom!
The text was updated successfully, but these errors were encountered: