Pulls in @types/node

[laino]

In build/esm/index.d.ts and build/cjs/index.d.ts the following line is emitted:

/// <reference types="node" />

This will cause any (in-)direct import to pull in node types, polluting the global namespace.

To illustrate why this is an issue:

import { Socket } from 'socket.io-client';

//  error TS2322: Type 'Timeout' is not assignable to type 'number'.
const timeout: number = setTimeout(() => {}, 0);

The issue was introduced with version 5.2.2 and this commit: socketio/engine.io-parser@0305b4a

The last good version is 5.2.1.

[darrachequesne]

For history, socketio/engine.io-parser@0305b4a was introduced in order to provide a fix for #5064.

That being said, it seems TypeScript v5.5 does not include the /// <reference types="node" /> part anymore: https://devblogs.microsoft.com/typescript/announcing-typescript-5-5/#simplified-reference-directive-declaration-emit

Let me check if this doesn't break other configurations...

[darrachequesne]

This should be fixed by f9cb983, included in engine.io-parser@5.2.3.

@laino could you please check?

[laino]

It's fixed. Thanks!