Allow disabling ping/pong?

[STRML]

It would be nice if a 0 value for pingInterval or pingTimeout could disable ping/pong checking entirely.

When used with an abstraction layer like Primus, the ping/pong is redundant and can sometimes cause situations where engine.io terminates the connection and Primus doesn't pick up on it. In those cases Primus might not reconnect.

[3rd-Eden]

@STRML if Primus doesn't pick up those connection terminations it's a bug in Primus so please report that in https://github.com/primus/primus as for the disabling of ping/pong's. I would love to see that as well.

[darrachequesne]

Closed due to inactivity, please reopen if needed.

[lpinca]

Maybe it makes sense to reopen as this was a feature request which I also support.

[darrachequesne]

PR is welcome!

[lpinca]

@darrachequesne thanks.
If I'm not wrong Engine.IO sends ping messages from client to server. We are currently doing the same in Primus but just FYI we are considering reversing the direction of pings and make the server send them to the client as browsers started to throttle timers. See primus/primus#348 if you are interested.

[darrachequesne]

@lpinca You're right, pings are sent by the client. But a timer is set on both the client and the server (allowing to detect any unavailability from the other side), isn't that the case with primus?

[lpinca]

Yes, but the client timer that sends the ping is delayed by the browser so the server incorrectly closes the connection.
Imagine that you used setTimeout(sendPing, 20000); on the client. The sendPing callback is not actually called after 20 sec but after 40 sec.

Hope it makes sense :)

[STRML]

This is something we'll have to be prepared for in every browser - Safari has been doing this for years, Chrome is next and I'm sure FF and IE are not far behind. We simply can't rely on client timers being anywhere near reliable. I've seen 130+ (!) delays in Chrome 56. Word from them is that they will set a max, but the writing is on the wall.

…

On Jan 22, 2017 3:28 PM, "Luigi Pinca" ***@***.***> wrote: Yes, but the client timer that sends the ping is delayed by the browser so the server incorrectly closes the connection. Imagine that you used setTimeout(sendPing, 20000); on the client. The sendPing callback is not actually called after 20 sec but after 40 sec. Hope it makes sense :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5082>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABJFP9A_SydFX0hUCYKgTSZY1IZojB5Uks5rU8npgaJpZM4Dp2fJ> .