[Regression error] Missing cookie in authorization function

[renajohn]

data.headers.cookie is null since 0.8.6 (working on 0.8.5). Authorization as bellow is broken.

sio.set('authorization', function (data, accept) {
    if (data.headers.cookie) {
        data.cookie = parseCookie(data.headers.cookie);
        data.sessionID = data.cookie['express.sid'];
        // save the session store to the data object 
        // (as required by the Session constructor)
        data.sessionStore = sessionStore;
        sessionStore.get(data.sessionID, function (err, session) {
            if (err) {
                accept(err.message, false);
            } else {
                // create a session object, passing data as request and our
                // just acquired session data
                data.session = new Session(data, session);
                accept(null, true);
            }
        });
    } else {
       return accept('No cookie transmitted.', false);
    }
});
``` (from http://www.danielbaulig.de/socket-ioexpress/)

[3rd-Eden]

Thats odd, as there aren't any changes for 0.8.5 to 0.8.6 that would affect this behavior..

dfebed3...abd0326

On Nov 7, 2011, at 12:38 PM, Renault John Lecoultre wrote:

data.headers.cookie is null since 0.8.6 (working on 0.8.5). Authorization as bellow is broken.

sio.set('authorization', function (data, accept) {
   if (data.headers.cookie) {
       data.cookie = parseCookie(data.headers.cookie);
       data.sessionID = data.cookie['express.sid'];
       // save the session store to the data object 
       // (as required by the Session constructor)
       data.sessionStore = sessionStore;
       sessionStore.get(data.sessionID, function (err, session) {
           if (err) {
               accept(err.message, false);
           } else {
               // create a session object, passing data as request and our
               // just acquired session data
               data.session = new Session(data, session);
               accept(null, true);
           }
       });
   } else {
      return accept('No cookie transmitted.', false);
   }
});
``` (from http://www.danielbaulig.de/socket-ioexpress/)

--- 
Reply to this email directly or view it on GitHub:
https://github.com/LearnBoost/socket.io/issues/625

[renajohn]

I've double checked, if I install socket.io v 0.8.5, data.headers.cookie is present, if I install v 0.8.6, data.headers.cookies is undefined.

[gavinuhma]

I tracked this down in socket.io-client: socketio/socket.io-client#333

[haohello]

I'm using the lates socket.io which is v0.9.3, the error still occurs in IE 6, delete the following line or add a if statement to check in IE 6 will fix it,

xhr.withCredentials = true;  (possibly add if not IE 6 conditional statement)