Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion for implementation of clients API #1966

Merged
merged 1 commit into from
Jan 31, 2015
Merged

Suggestion for implementation of clients API #1966

merged 1 commit into from
Jan 31, 2015

Conversation

cha0s
Copy link
Contributor

@cha0s cha0s commented Jan 26, 2015

No description provided.

@cha0s
Copy link
Contributor Author

cha0s commented Jan 26, 2015

References socketio/socket.io-adapter#24

This was referenced Jan 26, 2015
Merged
Closed
@rauchg
Copy link
Contributor

rauchg commented Jan 29, 2015

This API is 100% spot on

rauchg
rauchg reviewed Jan 29, 2015
View reviewed changes
Readme.md

```js
var io = require('socket.io')();
io.of('/chat').in('general').clients(function(error, clients){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add an example of getting all rooms

@cha0s
Copy link
Contributor Author

cha0s commented Jan 30, 2015

I added some examples to the docs

@barisusakli
Copy link

I assume, io.in('general').clients(); will also work?

@cha0s
Copy link
Contributor Author

cha0s commented Jan 30, 2015

Yeah, it reflects the broadcast API

@rauchg
Copy link
Contributor

rauchg commented Jan 30, 2015

We need to rebase again

@cha0s
Copy link
Contributor Author

cha0s commented Jan 30, 2015

I haven't done this for pull requests before. Do I just fix the history
and --force push? Will that work or will it screw things up?

On 01/30/2015 12:29 PM, Guillermo Rauch wrote:

We need to rebase again

—
Reply to this email directly or view it on GitHub
#1966 (comment).

@rauchg
Copy link
Contributor

rauchg commented Jan 30, 2015

Up to you. You can simply just merge from master and regular-push

@cha0s
Copy link
Contributor Author

cha0s commented Jan 31, 2015

Well I tried rebasing off master but I didn't get any changes... So, I just force pushed to squash it into one commit. That cool?

@cha0s
Copy link
Contributor Author

cha0s commented Jan 31, 2015

Nevermind, I forgot to sync my fork with upstream :) should be good now.

rauchg added a commit that referenced this pull request Jan 31, 2015
@rauchg
Merge pull request #1966 from cha0s/clients
97c6568 
Suggestion for implementation of clients API
@rauchg rauchg merged commit 97c6568 into socketio:master Jan 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cha0s @rauchg @barisusakli