feat: add details to the disconnecting and disconnect events #4622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hackatosh
changed the title
Hackatosh
changed the title
cbellier
approved these changes
Feb 3, 2023
darrachequesne
pushed a commit
that referenced
this pull request
Feb 4, 2023
|
Merged as 8aa9499. Thanks! |
|
@darrachequesne Thank you ! Could you please tell me when this will be released ? We need that in order to debug some issues on our production environment |
haneenmahd
pushed a commit
to haneenmahd/socket.io
that referenced
this pull request
Apr 15, 2023
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
New behavior
The "disconnecting" and "disconnect" events will now include additional details to help debugging if anything has gone wrong.
The goal is to mirror this change made to the client : socketio/socket.io-client@b862924