-
Notifications
You must be signed in to change notification settings - Fork 2
rename global package namespace and bump version to 4.0.0-SNAPSHOT #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: NeatGuyCoding <15627489+NeatGuyCoding@users.noreply.github.com>
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 145 files out of 252 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request renames the global package namespace from com.corundumstudio.socketio to com.socketio4j.socketio and bumps the version from 3.0.2-SNAPSHOT to 4.0.0-SNAPSHOT. This is a significant breaking change that affects all modules in the project.
Key changes:
- Package namespace renamed across all source files, tests, and configuration files
- Version bumped to 4.0.0-SNAPSHOT in all POM files
- Updated module-info.java exports to use new namespace
- Updated logging configurations, Spring/Quarkus/Micronaut auto-configuration files
Reviewed Changes
Copilot reviewed 252 out of 252 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Updated parent version and Maven plugin configurations with new namespace |
| netty-socketio-core/** | All core source files, tests, and module-info.java updated to new namespace |
| netty-socketio-spring/** | Spring module package and import updates |
| netty-socketio-spring-boot-starter/** | Spring Boot starter with configuration and test updates |
| netty-socketio-quarkus/** | Quarkus extension modules updated with new namespace |
| netty-socketio-micronaut/** | Micronaut module with factory service and configuration updates |
| netty-socketio-smoke-test/** | Performance test classes and configurations renamed |
| netty-socketio-examples/** | Example applications updated across all framework integrations |
| run-performance-test.sh | Shell script updated with new main class reference |
Comments suppressed due to low confidence (2)
netty-socketio-core/src/test/java/com/socketio4j/socketio/protocol/ConnPacketTest.java:154
- The expected class name prefix in the test assertion is incorrect after the package rename. It should be
com.socketio4j.socketio.protocol.ConnPacket@instead ofprotocol.com.socketio4j.socketio.ConnPacket@. The prefix should match the fully qualified class name.
netty-socketio-core/src/test/java/com/socketio4j/socketio/transport/WebSocketTransportTest.java:70 - The JavaDoc comment reference is incorrect after the package rename. It should be
com.socketio4j.socketio.transport.WebSocketTransport#channelInactiveinstead oftransport.com.socketio4j.socketio.WebSocketTransport#channelInactive. The package name appears to be in the wrong order.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: NeatGuyCoding <15627489+NeatGuyCoding@users.noreply.github.com>
Signed-off-by: NeatGuyCoding <15627489+NeatGuyCoding@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 252 out of 252 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
com.socketio4jType of Change
Related Issue
Closes #7
Testing
mvn testChecklist
Additional Notes
Any additional information, screenshots, or context that reviewers should know.