Skip to content

Conversation

@NeatGuyCoding
Copy link
Collaborator

@NeatGuyCoding NeatGuyCoding commented Nov 19, 2025

Description

  • Rename all packages' namespace to com.socketio4j
  • start 4.0.0-SNAPSHOT

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring
  • Test improvements
  • Build/tooling changes

Related Issue

Closes #7

Testing

  • All existing tests pass
  • New tests added for new functionality
  • Tests pass locally with mvn test
  • Integration tests pass (if applicable)

Checklist

  • Code follows project coding standards
  • Self-review completed
  • Code is commented where necessary
  • Documentation updated (if needed)
  • Commit messages follow conventional format
  • No merge conflicts
  • All CI checks pass

Additional Notes

Any additional information, screenshots, or context that reviewers should know.

Signed-off-by: NeatGuyCoding <15627489+NeatGuyCoding@users.noreply.github.com>
Copilot AI review requested due to automatic review settings November 19, 2025 09:14
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 19, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

145 files out of 252 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature-4.0.0-refactor-namespace

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request renames the global package namespace from com.corundumstudio.socketio to com.socketio4j.socketio and bumps the version from 3.0.2-SNAPSHOT to 4.0.0-SNAPSHOT. This is a significant breaking change that affects all modules in the project.

Key changes:

  • Package namespace renamed across all source files, tests, and configuration files
  • Version bumped to 4.0.0-SNAPSHOT in all POM files
  • Updated module-info.java exports to use new namespace
  • Updated logging configurations, Spring/Quarkus/Micronaut auto-configuration files

Reviewed Changes

Copilot reviewed 252 out of 252 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pom.xml Updated parent version and Maven plugin configurations with new namespace
netty-socketio-core/** All core source files, tests, and module-info.java updated to new namespace
netty-socketio-spring/** Spring module package and import updates
netty-socketio-spring-boot-starter/** Spring Boot starter with configuration and test updates
netty-socketio-quarkus/** Quarkus extension modules updated with new namespace
netty-socketio-micronaut/** Micronaut module with factory service and configuration updates
netty-socketio-smoke-test/** Performance test classes and configurations renamed
netty-socketio-examples/** Example applications updated across all framework integrations
run-performance-test.sh Shell script updated with new main class reference
Comments suppressed due to low confidence (2)

netty-socketio-core/src/test/java/com/socketio4j/socketio/protocol/ConnPacketTest.java:154

  • The expected class name prefix in the test assertion is incorrect after the package rename. It should be com.socketio4j.socketio.protocol.ConnPacket@ instead of protocol.com.socketio4j.socketio.ConnPacket@. The prefix should match the fully qualified class name.
    netty-socketio-core/src/test/java/com/socketio4j/socketio/transport/WebSocketTransportTest.java:70
  • The JavaDoc comment reference is incorrect after the package rename. It should be com.socketio4j.socketio.transport.WebSocketTransport#channelInactive instead of transport.com.socketio4j.socketio.WebSocketTransport#channelInactive. The package name appears to be in the wrong order.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: NeatGuyCoding <15627489+NeatGuyCoding@users.noreply.github.com>
Signed-off-by: NeatGuyCoding <15627489+NeatGuyCoding@users.noreply.github.com>
Copilot AI review requested due to automatic review settings November 19, 2025 09:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 252 out of 252 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NeatGuyCoding NeatGuyCoding merged commit 7b9477a into main Nov 19, 2025
10 checks passed
@NeatGuyCoding NeatGuyCoding deleted the feature-4.0.0-refactor-namespace branch November 19, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Can we entirely move to new namespace com.socketio4j

2 participants