fix: copy over rspec context to reactor thread #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were running into some issues using async-rspec in specs that were trying to access spec metadata.
In our case, we're using a rspec-snapshot to let us match against snapshots, which uses the spec metadata to construct a directory path to load snapshots from. When we initialize said matcher in a spec example running inside the reactor, that metadata is nil, since it's stored as a thread-local variable.
The workaround here is just copying over the RSpec thread-local variables into the reactor block.
Types of Changes
Contribution