If a task returns an exception value, do not raise it in #wait. (#270)

socketry · Aug 14, 2023 · 72ca9ca · 72ca9ca
1 parent 7773705
commit 72ca9ca
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/async/task.rb b/lib/async/task.rb
@@ -190,7 +190,7 @@ def wait
 				@finished.wait
 			end
 
-			if @result.is_a?(Exception)
+			if @status == :failed
 				raise @result
 			else
 				return @result

diff --git a/test/async/task.rb b/test/async/task.rb
@@ -711,6 +711,13 @@ def sleep_forever
 			expect(error_task).to be(:finished?)
 			expect(innocent_task).to be(:finished?)
 		end
+
+		it "will not raise exception values returned by the task" do
+			error = StandardError.new
+			task = reactor.async { error }
+			expect(task.wait).to be == error
+			expect(task.result).to be == error
+		end
 	end
 
 	with '#result' do