Ensure transient tasks are correctly terminated. #245
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #244.
Top level transient tasks are a bit odd. The event loop is considered already
finished?
and thus won't execute a single iteration. However, in order to terminate the event loop, any and all child tasks need to be stopped.The following program causes a hang:
Scheduler#close
method is invoked, which enters the terminate loop.Task#stop
is invoked on the top level task which stops the child task by raising and exception, but itself is not stopped yet. Raising an exception transfers to the child task.run_once
considers the scheduler is finished, it does not resume the parent task.The fix, I think, is to avoid checking
self.finished?
when performing the termination loop. Tests added based on the original report.Types of Changes
Contribution