Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly pass through flags rb_process_status_wait. #81

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

ioquatix
Copy link
Member

@ioquatix ioquatix commented Aug 29, 2023

rb_process_status_wait is not exposed yet in CRuby, but when/if it is, it will take a flags argument.

WNOHANG should always be set, as it's used to (efficiently) by-pass the fiber scheduler.

Types of Changes

  • Bug fix.
  • New feature.
  • Maintenance.

Contribution

@ioquatix ioquatix force-pushed the rb_process_status_wait branch from 819494b to 44e78a8 Compare August 29, 2023 08:51
@ioquatix ioquatix force-pushed the rb_process_status_wait branch from 44e78a8 to 07696b6 Compare August 29, 2023 09:01
@ioquatix ioquatix merged commit 11d8bb2 into main Aug 29, 2023
@ioquatix ioquatix deleted the rb_process_status_wait branch August 29, 2023 11:06
@ioquatix
Copy link
Member Author

See ruby/ruby#8316 for more context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant