Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compatibility patch. #24

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Remove compatibility patch. #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/protocol/http2/stream.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,6 @@ def send_headers?

# The HEADERS frame is used to open a stream, and additionally carries a header block fragment. HEADERS frames can be sent on a stream in the "idle", "reserved (local)", "open", or "half-closed (remote)" state.
def send_headers(*arguments)
if arguments.first.nil?
arguments.shift # Remove nil priority.
end

if @state == :idle
frame = write_headers(*arguments)

Expand Down
2 changes: 1 addition & 1 deletion test/protocol/http2/connection.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ def before

it "can create new stream and send response" do
# First argument is deprecated priority.
stream.send_headers(nil, request_headers)
stream.send_headers(request_headers)
expect(stream.id).to be == 1

expect(server).to receive(:receive_headers) do |frame|
Expand Down
Loading