ssc-setup fixes #308
Merged
ssc-setup fixes #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwerle
added
bug
chicoxyzzy
approved these changes
Apr 6, 2023
we'll come back and do a complete pass on docs for the scripts 🙏🏼 |
jwerle
commented
Apr 6, 2023
* chore: new release * chore(npm): @socketsupply/socket-linux-x64@0.0.7 * chore(npm): @socketsupply/socket-win32-x64 * chore(npm): bump top-level package version * publish-npm-modules: disable checks when --only-top-level * publish-npm-modules: disable android checks for linux-aarch64 * install.sh: disable BUILD_ANDROID for linux-aarch64 --------- Co-authored-by: Sergey Rubanov <chi187@gmail.com> Co-authored-by: Joseph Werle <joseph.werle@gmail.com> Co-authored-by: heapwolf <paolo@socketsupply.co>
…copied SOCKET_API_HOME
'functions.sh' leaks variables into sourced files like $root causing unexpected behaviour
mribbons
suggested changes
Apr 6, 2023
| @@ -114,6 +114,10 @@ String getSocketHome (bool verbose) { | |||
| static String LOCALAPPDATA = getEnv("LOCALAPPDATA"); | |||
| static String SOCKET_HOME = getEnv("SOCKET_HOME"); | |||
| static String HOME = getEnv("HOME"); | |||
| static const bool SSC_DEBUG = ( | |||
| getEnv("SSC_DEBUG").size() > 0 || | |||
There was a problem hiding this comment.
Nice. I think we also need to look at differentiating between debug output and debug builds in install.sh and install.ps1.
mribbons
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves
ssc setupin various ways including the output during the FTE and setup to give users more feedback about what is going on aligning the output style with the rest of build scripts.