-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESC in Firefox breaks sockjs connection #18
Comments
There isn't going to be a fix for that. Users have to cope. |
"There isn't going to be a fix for that." Can you elaborate on that? Currently it completely messes up my UX flow. |
Sure. This is a well known problem (that's why it's documented). Fixing this is out of the scope for SockJS - that would require messing with user key events, which isn't SockJS responsibility by any means. I haven't run this in anger, but just catching the esc key in jquery seems to be working fine, please tell me if that works for you:
|
See also this bugzilla discussion. https://bugzilla.mozilla.org/show_bug.cgi?id=614304 |
@jwheare Great, thanks for the link! |
@majek Your workaround causes that F5 is not working anymore in Firefox (tested with FF 11.0 in Ubuntu Linux 64 Bit). Better use this (taken from the bugzilla link) as a workaround:
|
@alp82 Brilliant, thanks! |
retryDelayed: Use milliseconds subscribe(): Pass callback unsubscribe(): No start and data message(): No channel message(): Rename to send() (like in WS) onConnect -> onopen onDisconnect -> onclose Drop onMessage ESC fix: sockjs/sockjs-client#18 Constructor: Remove protocols, don't set whitelist manually
Protip for anyone finding this on Google: This is no longer an issue. Mozilla fixed it on the Firefox side. |
@graue , really? |
While the page is still loading, I assume that it will break WebSocket connections :) It'll also break downloading images, CSS and JavaScript. That's what clicking "Stop" or pressing Escape is supposed to do :) But anytime the Stop button is hidden/disabled in Firefox, Escape does nothing at the browser level. So the problem people were talking about in 2011 is gone. |
As found out by the Socket.io people:
http://groups.google.com/group/socket_io/browse_thread/thread/a705e4cb532e8808
The text was updated successfully, but these errors were encountered: