Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix image build failure #335

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

nohzafk
Copy link
Contributor

@nohzafk nohzafk commented Jan 6, 2025

Remove the platform parameter from Dockerfile

We should remove the fixed --platform=linux/amd64 from Dockefile to allow docker to choose right architecture when pulling the image.

If this change affects the github action, we should specify the platform parameter on github action task

Fix poetry version issue

When I try to build the image using docker compose build today, it failed due to a breaking change of poetry 2.0.0.

We need to put a constrain of 'poetry<2.0.0' for now.

docker compose build

> [django-socio-grpc server 1/1] RUN poetry install:
0.493
0.502 The Poetry configuration is invalid:
0.502   - project must contain ['name'] properties

Others are experiencing the same issue

@legau
Copy link
Contributor

legau commented Jan 6, 2025

This Poetry 2.0 has broken lots of things for us, a reminder to always put constraint on versions

@legau legau merged commit 8422781 into socotecio:master Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants