Use escaped quotes for Windows INSTALLDIR #100
Conversation
The Java .exe installers expect that INSTALLDIR variables containing spaces be surrounded by quotes *in the variable itself*. Thus the command line quotes need to be escaped. This means we need to double escape the quotes in Ruby.
Use escaped quotes for Windows INSTALLDIR
|
Is this the preferred approach, or is #90 ? |
|
It looks like these are separate issues, but I'd to hear from you Windows folks - should both of these be merged? This fixes install dir, the other cache dir. |
|
I think that this broke the installation of a JDK with the java cookbook on Windows. I think that this fix works only with a JRE. For example, if I download both a JRE and a JDK here : http://www.oracle.com/technetwork/java/javase/downloads/jdk7-downloads-1880260.html and here http://java.com/en/download/manual.jsp#win .\jdk-7u51-windows-x64.exe /s INSTALLDIR="C:\java" The second one works, but the first one doesn't. It does when I remove the backward slashes. |
|
OK this is my attempt at fixing it : #131 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
When installing Java on Windows, the Java EXE installer expects that the INSTALLDIR variable to contain quotes if there are spaces in the path. This means quotes need to be escaped on the command line. For example, this does not work:
but this does:
I suspect this is because they are passing the arguments as a string to the MSI.
Since the quotes need to be escaped on the command line, they need to be double escaped in Ruby.