[COOK-3857] do not unescape the java windows url before parsing it

[b-dean]

https://tickets.opscode.com/browse/COOK-3857

[carmstrong]

Is this still necessary after merging #100 ?

[b-dean]

Absolutely. Here's an example. Let's say that node['java']['windows']['url'] had a value of http://localhost:8080/Oracle%20Java/1.6.0_45/jdk-6u45-windows-x64.exe If you unescape that, then try to parse it, it will fail to parse. URI.parse cannot parse URIs that have unescaped characters. You can see that even in irb:

1.9.3p484 :001 > require 'uri'
 => true 
1.9.3p484 :002 > java_uri = 'http://localhost:8080/Oracle%20Java/1.6.0_45/jdk-6u45-windows-x64.exe'
 => "http://localhost:8080/Oracle%20Java/1.6.0_45/jdk-6u45-windows-x64.exe" 
1.9.3p484 :003 > URI.parse(java_uri)
 => #<URI::HTTP:0x00000000f343c8 URL:http://localhost:8080/Oracle%20Java/1.6.0_45/jdk-6u45-windows-x64.exe> 
1.9.3p484 :004 > URI.parse(URI.unescape(java_uri))
URI::InvalidURIError: bad URI(is not URI?): http://localhost:8080/Oracle Java/1.6.0_45/jdk-6u45-windows-x64.exe
    from /usr/local/rvm/rubies/ruby-1.9.3-p484/lib/ruby/1.9.1/uri/common.rb:176:in `split'
    from /usr/local/rvm/rubies/ruby-1.9.3-p484/lib/ruby/1.9.1/uri/common.rb:211:in `parse'
    from /usr/local/rvm/rubies/ruby-1.9.3-p484/lib/ruby/1.9.1/uri/common.rb:747:in `parse'
    from (irb):4
    from /usr/local/rvm/rubies/ruby-1.9.3-p484/bin/irb:12:in `<main>'

[carmstrong]

Cool, thanks for confirming. Trying to clean up these old PRs.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.